Helm dashboard v2 #394
Helm dashboard v2 #394
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
- Coverage 29.87% 29.85% -0.02%
==========================================
Files 10 10
Lines 1339 1323 -16
==========================================
- Hits 400 395 -5
+ Misses 900 887 -13
- Partials 39 41 +2
☔ View full report in Codecov by Sentry. |
* Call linter in CI * Change static files location for go backend * Fix docker build * Static changes * Fixes for build * More timeout * Placeholder in dir
| @@ -0,0 +1,10 @@ | |||
| #!/bin/bash -e | |||
There was a problem hiding this comment.
I guess this file is not needed anymore, we configured it via vite config
dashboard/index.html
Outdated
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Helm Dashboard</title> | ||
| <script src="/static/analytics.js"></script> | ||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/10.7.1/styles/github.min.css" /> |
There was a problem hiding this comment.
Why do we load it like this? AFAIK there is a way to install it like npm install highlight.js
| href="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.13.1/styles/lightfair.min.css" | ||
| /> | ||
|
|
||
| <link |
There was a problem hiding this comment.
Same question on these CSS - isn't there more canonical way to include these CSS into React app?
dashboard/src/assets/react.svg
Outdated
| @@ -60,6 +65,22 @@ func contextSetter(data *objects.DataLayer) gin.HandlerFunc { | |||
| } | |||
| } | |||
|
|
|||
| // Middleware for CORS | |||
| func corsMiddleware() gin.HandlerFunc { | |||
There was a problem hiding this comment.
This has to be gone in favor of allowCORS() function that is triggered via env variable. By that, there will be no security risk of forgetting dev code pieces.
Changes Proposed
Check List